Add 2 unmarshal tag Semgrep rules #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrosQuildu
approved these changes
Apr 22, 2025
Vasco-jofra
force-pushed
the
VF/unmarshal_rules
branch
from
403f1ba to
8cdba18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 2 rules detect common misconfigurations on JSON/XML/YAML tags.
Here are some examples of these issues found in the OSS repos.
unmarshal-tag-is-dash:ClientIDfield on an OIDC configuration as the-field (fixed in #3658)MaxTokensfield as the-field (fixed in #1163)unmarshal-tag-is-omitempty:Argsfield of theTranslatableMessagestructure with the omitempty key. (fixed in #33663)Replacementsfiled of thepluginstructure with the omitempty key (fixed in #5877)